Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…bles in the shared cmd test helper. That keeps project/cloud config tests from accidentally picking up the host shell’s ENGRAM_PROJECT and ENGRAM_CLOUD_SERVER values, which was causing the suite to fail under this environment.
|
Closing this PR because #681 is still awaiting design approval, and the maintainer discussion correctly identified this implementation as premature while deletion, authorization, and sync semantics remain unsettled. The current head is also a large conflicting draft. Please keep the product and safety contract on #681. If that design is approved later, the implementation should restart as a focused change against current |
🔗 Linked Issue
Closes #681
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking change📝 Summary
📂 Changes
🧪 Test Plan
go test ./...go test -tags e2e ./internal/server/...🤖 Automated Checks
All repository checks must pass before merge.
✅ Contributor Checklist
681withCloses #681type:featurelabel to this PRCo-Authored-Bytrailers in commits