feat(shell): describe RDD sidebar states by what is happening

[Alan-TheGentleman]

Refs #1438

Summary

• The 🌹 RDD Status group now says what is happening and who acts, instead of internal state names (for example closed → ✓ Approved, consent → Needs your consent, approved → Approved · finalizing…).
• The file line reads first.ts +N files, and is omitted when the candidate scope is unknown instead of showing "Candidate scope unavailable".
• Display only: snapshot derivation, publisher correlation, and review authority are unchanged; REVIEW_SCOPE_UNAVAILABLE stays as the internal sentinel.

Labels

State	Before	After
checking	Checking review	Updating…
reviewing	Reviewing	Reviewers running…
in_review	In review	Review in progress
forecast	Awaiting reviewer run	Preparing reviewers…
ready	Ready for review	Not reviewed yet
consent	Awaiting consent	Needs your consent
correction	Correction required	Fixing findings…
approved	Approved · awaiting acknowledgement	Approved · finalizing…
closed	Closed	✓ Approved
declined	Declined	Skipped for this change
invalidated	Invalidated	Outdated · code changed
unavailable	Unavailable	Review unavailable
unknown	Unknown	Status unknown

Changes

File	Change
lib/review-sidebar-state.ts	New label texts; +N files scope wording
lib/shell-bar.ts	Scope line omitted for the unknown-scope sentinel
tests/review-sidebar-state.test.ts, tests/shell-bar.test.ts, tests/gentle-shell.test.ts	Label table, pluralization, sentinel omission, renamed label assertions
odd/tasks/rdd-sidebar-labels.md	ODD feature document

Test plan

• Rebased on main after feat(shell): add an RDD toggle to visual Sections #1507 (the RDD Sections toggle); the combined RDD group keeps both the visibility check and the scope omission.
• node --experimental-strip-types --test tests/*.test.ts: 3935 pass, 0 fail, 43 skipped
• node scripts/check-types.mjs: 188 recorded diagnostics, no regressions
• node scripts/check-provider-contract.mjs: passed; tests/runtime-harness.mjs: exit 0
• Native review: review-f837dc6e7581e272 and the integration test fix review-10c89d8cccd0283e, both approved
• Shellcheck: not applicable

Checklist

• Linked issue (Refs #1438)
• Exactly one type:* label
• Conventional commits, no Co-Authored-By trailers

Summary by CodeRabbit

• Improvements
  • Review sidebar labels now distinguish reviews in progress, reviewers running, approval finalization, and confirmed closure.
  • Candidate scope counts include “file” or “files” for clarity.
  • Unavailable review scope is no longer shown, keeping the sidebar more compact.
  • The pending refresh label now reads “Updating…”.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 20fe8a93-db32-46bb-950e-da8e992ada79

📥 Commits

Reviewing files that changed from the base of the PR and between 8c5e8a1 and 07992a0.

📒 Files selected for processing (6)

• lib/review-sidebar-state.ts
• lib/shell-bar.ts
• odd/tasks/rdd-sidebar-labels.md
• tests/gentle-shell.test.ts
• tests/review-sidebar-state.test.ts
• tests/shell-bar.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The review sidebar now uses revised labels for review states, includes singular or plural file counts in candidate scope, and omits the scope row when scope is unavailable. Tests and task documentation cover these display rules.

Changes

Review sidebar display

Layer / File(s)	Summary
Review labels and candidate scope lib/review-sidebar-state.ts, tests/review-sidebar-state.test.ts, tests/gentle-shell.test.ts, odd/tasks/rdd-sidebar-labels.md	The review-state labels are revised, and candidate scope uses file or files after additional-file counts. Tests and task documentation reflect the display rules.
Unavailable scope rendering lib/shell-bar.ts, tests/shell-bar.test.ts, tests/review-sidebar-state.test.ts	The sidebar omits the scope row when scope is unavailable. Tests cover the omitted row and its effect on sidebar height.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 07992

The changes update sidebar wording and scope display without changing review-state routing. No material merge risk was established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: updating RDD sidebar labels to describe the current activity and actor.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}