html encode user name#16
Open
white-gthb wants to merge 1 commit into
Open
Conversation
Author
|
Theoretically it might also be possible to set up phpBB to allow for quote characters to be used in user names. |
Author
|
Add mention: @LukeWCS |
Author
|
Seems my PR is still open but removed from the index by GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A moderator put quotes around his name in the bbc code
[mod="name"]resulting in faulty HTML and causing the mask values not to be replaced and even caused500 Internal Server Error. The entire thread on the forum could no longer be accessed.The text behind mod= should not be blindly inserted into
<MOD mod="...".Beside my fix to use htmlentities(), it is perhaps also wise to limit the user name to a certain max length before calling htmlentities().