Repository navigation
AI-3368: publish Kotlin only from a release PR merge #2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−9
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1c03f44
ci(kotlin): publish a release only from the merge of a release-kotlin PR
kanat 7c35b15
AI-3368: say how to re-run a release merge whose lookup lagged
kanat 976c5d9
AI-3368: name the org secrets the release environment does not limit
kanat 3655443
AI-3368: say AI-3372 tracks limiting the release secrets, not moves them
kanat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Should fix] R1.1 If the commit-to-PR lookup comes back empty right after a release merge (API lag), the run ends green. It shows only a
::noticeand creates no tag. Nothing here, in the workflow header or in the notice tells the owner what to do. The fix is to re-run all jobs of that run: a re-run keepsGITHUB_SHA, queries the API again, and findsversionabove the last tag and not published, so it publishes and tags. Please add one sentence here and in the header (publish-sdk-kotlin.yml:12-13), e.g. "If the run of a release merge says Nothing is published, re-run all its jobs". Please also say in the PR body that a release merge whose version is already tagged now fails "already released" where it used to give none.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7c35b15: the README (sdks/kotlin/README.md:385-387) and the workflow header (:13-14) say a release merge whose run says nothing is published is recovered by re-running all its jobs, and the notice (:70) names the same re-run. Test: author's run-cases.sh pins the notice text in 6 cases; reverting the added sentence changes those 6 notice lines (killed). Header and README wording are text only, so no mutation applies to them.