Skip to content

ci: run only the checks a change needs, and share one runner for the SDKs - #2126

Merged
kanat merged 1 commit into
mainfrom
ci/reduce-parallel-jobs
Nov 19, 2026
Merged

kanat merged 1 commit into
mainfrom
ci/reduce-parallel-jobs

Conversation

@oliverlaz

Copy link
Copy Markdown
Member

Why

Every PR started all 11 CI (unit) jobs, whatever it changed. With 60 runners for the whole organization, jobs on recent PRs waited 26–43 minutes for a runner and then ran for 0.3–16 minutes. At 13:34 on 19 Nov, six model PRs pushed together asked for ~126 jobs.

What changes

Workflow Jobs Starts when a PR or merge changes
ci-python.yml — CI (Python) 2 (lint, tests) **/*.py, **/pyproject.toml, uv.lock, pytest.ini, sdks/python, plugins, tests, the spec, examples/text_agents/mcp_plugins (a plugin test loads it)
ci-go.yml — CI (Go) 1 acceleration, sdks/go, tui, performance_benchmark, go.work*, the go.mod/go.sum of the six example modules go.work uses
ci-sdks.yml — CI (SDKs) 1 any server SDK, the spec, sdks/testdata/ui, the swift_assistant a2ui files the Go SDK's ui_test.go reads
  • ci.yml is split into the three workflows above, each started by GitHub's built-in paths: trigger. There is no extra job and no third-party action. Each job's steps are unchanged.
  • The six server SDKs (Go, JS, .NET, PHP, Rust, Ruby) now run one after another on one runner, about 5–6 min in all. !cancelled() keeps checking the remaining SDKs after one fails, and step names start with the SDK.
  • The stream-chat 10 suite now runs as the last JS steps instead of its own job.
  • sdk-go.yml is deleted: it repeated the Go SDK check.
  • python-versions.yml checks 3.10–3.14 in one job, two at a time. Each version's output is printed even when the job fails, is cancelled or times out.
  • The dashboard job is dropped: dashboard/ no longer exists.

Expected effect

Push Before After
Go-only PR, every workflow 21 jobs · ~92 min 11 jobs · ~77 min
Python-only PR 15 jobs · ~30 min 6 jobs · ~14 min
CI only, last 25 PRs replayed 264 jobs · ~600 min 26 jobs · ~190 min

No check that still runs takes longer. The slowest part of a PR stays Integration's store group (~16 min) or the Go job (~10 min).

Good to know

  • None of the three checks may be made required. A PR that doesn't trigger a workflow would wait forever on its check. None is required today.
  • Merges to main run only the affected workflows, as integration.yml and client-sdks.yml already do.
  • Kotlin, Dart and example-app-only PRs start none of the three. CI (client SDKs) still covers them.
  • A .py file under .claude/ now runs CI (Python). Ruff lints those scripts.
  • This PR changes all three workflow files, so every new workflow should run on it.

How it was checked

Not run on GitHub before this PR. Locally:

  • Workflow files: every changed workflow loads, and push and pull-request use the same paths.
  • Trigger paths: the changed files of the last 25 PRs and 11 targeted cases (the .md re-includes, example Go modules inside and outside go.work, the spec) start the expected workflows.
  • Python-versions scripts: run with a stub uv that fails one version, plus an unfinished and a never-started version.

Analysis and next steps (Integration is now about two-thirds of a Go PR's runner time): https://claude.ai/artifact/B6cu8YsL1DE9g6m13JbDKD

…SDKs

Every pull request started all 11 CI (unit) jobs whatever it changed, and with
60 runners for the organization, jobs waited 26-43 minutes for one while
running for 0.3-16 minutes.

- Split ci.yml into CI (Python), CI (Go) and CI (SDKs), each started by
  GitHub's `paths:` trigger only when its own files change. None of them may
  be a required check: a PR that does not trigger one would wait on it.
- Check the six server SDKs one after another on one runner. `!cancelled()`
  keeps checking the rest after one fails.
- Fold the stream-chat 10 suite into the JS steps.
- Delete sdk-go.yml: the Go SDK steps of CI (SDKs) are the same check.
- Resolve Python 3.10-3.14 in one job, two at a time, printing each
  version's output even when the job fails or times out.
- Drop the dashboard job: dashboard/ no longer exists.

Replaying the last 25 PRs, CI starts 26 jobs (~190 runner-minutes) instead
of 264 (~600).
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Walkthrough

This change replaces the removed shared CI workflows with separate CI (Go), CI (Python), and CI (SDKs) workflows. The new workflows add scoped path filters, read-only permissions, and concurrency cancellation. CI (Go) adds Redis-backed and generated-file checks across backend, SDK, terminal UI, and benchmark modules. CI (SDKs) adds sequential checks for Go, JS, .NET, PHP, Rust, and Ruby SDKs. The Python version resolver now runs versions 3.10 to 3.14 in one job with per-version logs. Related comments and release instructions now reference the new workflow names.

Merge Risk: Low · up to d1252

The CI split leaves one coverage gap: a PR that changes only the Go SDK README no longer runs the test that checks it against the quickstart example. The gap is narrow and cheap to close by adding the README to the workflow path filters, so it is a bounded follow-up rather than a merge blocker.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ab01365 and d125242.

Files selected for processing: 11

  • .claude/skills/sdk-go/SKILL.md
  • .github/workflows/ci-go.yml
  • .github/workflows/ci-python.yml
  • .github/workflows/ci-sdks.yml
  • .github/workflows/ci.yml
  • .github/workflows/integration.yml
  • .github/workflows/python-versions.yml
  • .github/workflows/sdk-go.yml
  • sdks/js/tests/agent-chat-transport.test.ts
  • sdks/js/tests/session.test.ts
  • sdks/js/tests/stream-chat.ts
Files with no reviewable changes: 2

  • .github/workflows/ci.yml
  • .github/workflows/sdk-go.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

- 'sdks/testdata/ui/**'
- 'examples/voice_agents/swift_assistant/a2ui/prompt.json'
- 'examples/voice_agents/swift_assistant/app/SwiftAssistant/UIComponents.json'
- '!**/*.md'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Keep the Go README test triggered.

If a PR changes only sdks/go/README.md, the Markdown exclusion prevents this workflow from starting. ci-go.yml excludes that file too. The deleted sdk-go.yml included it, and TestTheReadmesQuickstartIsTheQuickstartExample reads its first Go block. A README-only change can now bypass that check. (github.com)

Add sdks/go/README.md after the Markdown exclusion in both event lists. Keep other Markdown files excluded.

As per path instructions, flag “skipped required work” and “weakened tests.”

Source: Path instructions

@kanat
kanat merged commit 4ddb3ad into main Nov 19, 2026
18 checks passed
@kanat
kanat deleted the ci/reduce-parallel-jobs branch November 19, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants