Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .claude/skills/pr/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ description: Create a draft pull request for the Vision-Agents repo using gh CLI
## Creating

- Always `gh pr create --draft`. Push the branch first.
- A draft runs no CI, only CodeQL and the labeler. `gh pr ready` starts CI, and every push after it runs CI again, so mark it ready once the branch is done, not before.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Qualify when marking a PR ready starts CI.

The six workflows retain path filters. A PR that changes only this skill file does not match any of them, so gh pr ready starts none of those workflows. State that ready events and later pushes run the workflows only when their filters match. (docs.github.com)

- Follow `.github/pull_request_template.md`. Read every commit on the branch, do not summarise from the latest commit alone.

## Title
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/ci-go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ on:
- '!**/*.md'
pull_request:
branches: [ "**" ]
# A draft runs nothing: CI starts when the pull request is marked ready (ready_for_review)
# and runs on every push after that. The default types leave out ready_for_review.
types: [ opened, synchronize, reopened, ready_for_review ]
paths:
- 'acceleration/**'
- 'sdks/go/**'
Expand Down Expand Up @@ -67,6 +70,7 @@ concurrency:

jobs:
go:
if: github.event.pull_request.draft != true
runs-on: ubuntu-latest
# Every backend test that needs Redis skips without ROUTER_REDIS_ADDR: the service gives
# them one, on a host port the runner picks so a port already held on the runner cannot
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/ci-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ on:
- 'examples/text_agents/mcp_plugins/**'
pull_request:
branches: [ "**" ]
# A draft runs nothing: CI starts when the pull request is marked ready (ready_for_review)
# and runs on every push after that. The default types leave out ready_for_review.
types: [ opened, synchronize, reopened, ready_for_review ]
paths:
- '**/*.py'
- '**/pyproject.toml'
Expand Down Expand Up @@ -55,6 +58,7 @@ concurrency:
jobs:
# No secrets: unit tests reach no provider, and a pull request's code runs here.
unit:
if: github.event.pull_request.draft != true
uses: ./.github/workflows/run_tests.yml
with:
marker: 'not integration'
4 changes: 4 additions & 0 deletions .github/workflows/ci-sdks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ on:
- 'examples/voice_agents/swift_assistant/a2ui/instructions.md'
pull_request:
branches: [ "**" ]
# A draft runs nothing: CI starts when the pull request is marked ready (ready_for_review)
# and runs on every push after that. The default types leave out ready_for_review.
types: [ opened, synchronize, reopened, ready_for_review ]
paths:
- 'sdks/go/**'
- 'sdks/js/**'
Expand Down Expand Up @@ -54,6 +57,7 @@ concurrency:
jobs:
# Every step runs after a failure (`!cancelled()`), so each SDK reports its result.
sdks:
if: github.event.pull_request.draft != true
runs-on: ubuntu-latest
# For the Go SDK, the only Go here: it is installed on its own, with no go.work, by Go as
# old as its go directive, so it is checked that way too. GOTOOLCHAIN=local keeps 1.25
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/client-sdks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ on:
- '.github/workflows/client-sdks.yml'
pull_request:
branches: [ "**" ]
# A draft runs nothing: CI starts when the pull request is marked ready (ready_for_review)
# and runs on every push after that. The default types leave out ready_for_review.
types: [ opened, synchronize, reopened, ready_for_review ]
paths:
- 'sdks/kotlin/**'
- 'sdks/swift/**'
Expand All @@ -41,6 +44,7 @@ jobs:
# A pull request builds only the SDKs it touches, so a Dart change does not wait on the
# macOS runner. A push to main builds them all.
changes:
if: github.event.pull_request.draft != true
runs-on: ubuntu-latest
outputs:
kotlin: ${{ steps.filter.outputs.kotlin }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ on:
- '.github/workflows/integration.yml'
pull_request:
branches: [ "**" ]
# A draft runs nothing: CI starts when the pull request is marked ready (ready_for_review)
# and runs on every push after that. The default types leave out ready_for_review.
types: [ opened, synchronize, reopened, ready_for_review ]
paths:
- 'acceleration/**'
- '!**/*.md'
Expand All @@ -37,6 +40,7 @@ permissions:

jobs:
integration:
if: github.event.pull_request.draft != true
name: integration (${{ matrix.group }})
runs-on: ubuntu-latest
# MEM0_API_KEY lives in this environment, which a pull request's code never enters.
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/python-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
- '.github/workflows/python-versions.yml'
pull_request:
branches: [ "**" ]
# A draft runs nothing: CI starts when the pull request is marked ready (ready_for_review)
# and runs on every push after that. The default types leave out ready_for_review.
types: [ opened, synchronize, reopened, ready_for_review ]
paths:
- '**/pyproject.toml'
- 'uv.lock'
Expand All @@ -29,6 +32,7 @@ jobs:
# into its own log so their output does not interleave. Every version is checked even after
# one fails, and the job fails at the end, naming the versions that did not resolve.
resolve:
if: github.event.pull_request.draft != true
name: Resolve on Python 3.10–3.14
runs-on: ubuntu-latest
env:
Expand Down
Loading