Skip to content

refactor: remove region_tags redudancy on Endpoints Kubernetes tutorial #10284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kef131 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove region_tags redudancy on Endpoints Kubernetes tutorial #10284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions endpoints/getting-started/k8s/esp_echo_http.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,10 @@ spec:
labels:
app: esp-echo
spec:
# [START endpoints_secret1_yaml_java]
volumes:
- name: service-account-creds
secret:
secretName: service-account-creds
# [END endpoints_secret1_yaml_java]
# [START endpoints_service_yaml_java]
containers:
- name: esp
image: gcr.io/endpoints-release/endpoints-runtime:1
Expand All @@ -55,15 +52,12 @@ spec:
"--rollout_strategy", "managed",
"--service_account_key", "/etc/nginx/creds/service-account-creds.json",
]
# [END endpoints_service_yaml_java]
ports:
- containerPort: 8080
# [START endpoints_secret2_yaml_java]
volumeMounts:
- mountPath: /etc/nginx/creds
name: service-account-creds
readOnly: true
# [END endpoints_secret2_yaml_java]
- name: echo
image: gcr.io/endpoints-release/echo:latest
ports:
Expand Down