fix: keep modals open when dragging over backdrop - #6827
Open
sridharkalaibala wants to merge 1 commit into
Open
sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6683.
A press inside the dialog followed by a release on the backdrop can generate a click targeted at the modal container, closing the editor while the user is dragging or selecting text. Track whether the press or release occurred inside the dialog and ignore the resulting backdrop click. Reset the gesture state after the click so the next complete backdrop click still closes normally.
The reverse gesture (backdrop to dialog) also stays open. The close button and
backdrop: falsebehavior are preserved.Validation:
em.Modalto the modal model, matching the production module/configuration; the old fixture passed the whole editor and had no backdrop setting.git diff --checkpass.backdropboth true and false, without page errors.Tested on Windows with Node 24.19 and pnpm 9.10.0. The browser fixture uses the real
editor.Modal.open()path; the external custom-code plugin from the issue was not installed. Generated build artifacts and dependencies are excluded.AI assistance: OpenAI Codex was used for investigation, implementation, and validation.