fix: cancel pending style manager updates on destroy - #6829
Open
sridharkalaibala wants to merge 1 commit into
Open
sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style Manager cancels its debounced selection refresh during destruction, but leaves two other callbacks queued: property updates and custom events. A style change followed immediately by editor destruction still invokes the property updater; a target change followed by module destruction still emits a custom event.
Retain both debounced functions and cancel them alongside
upAllafter stopping listeners. This keeps deferred work from running after teardown without changing live update behavior.Related to #6494. I investigated the rapid create/destroy report but could not reproduce its original exception on the current build; this PR addresses the confirmed incomplete cleanup and intentionally does not close that issue.
Validation:
Prepared with AI assistance and validated locally using Node 24.19.0 and pnpm 9.10.0. No dependency, lockfile, or public API changes.