Vlen string attributes - #28
Merged
Merged
Conversation
bsp_read_attribute_allocator sized its buffer with H5Tget_size(), which for a variable-length string type returns the size of a pointer rather than the length of the string, and H5Aread writes a pointer into that buffer. Branch on H5Tis_variable_str() so both layouts are read correctly. The fixed-size path is unchanged, so files written by earlier versions of Binsparse continue to be read. This lands ahead of the corresponding writer change so that no revision writes attributes it cannot read back. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The binsparse JSON attribute was written with a fixed-size string type. h5py surfaces that as a numpy.bytes_ of dtype |S<n> rather than as a str, so callers have to know to decode it. Write it as a variable-length UTF-8 string instead, which is what h5py itself produces and what Binsparse already uses for string datasets. The resulting datatype compares equal under H5Tequal to one written by h5py, and h5py now returns a str. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.