Add Pirate's Treasure quest - #1225
Merged
Merged
Conversation
Contributor
Qodana for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Covers the full quest: Redbeard Frank's rum bargain, taking a job on
Luthas' banana plantation to smuggle a bottle past the customs officer,
Wydin's back room, Hector's chest in the Blue Moon Inn, and digging up
the casket in Falador park.
The shipped script referenced items and npcs that don't exist here
(karamja_rum, piratemessage, pirate_casket, chest_key, redbeard_frank,
luthas, customs_officer), so every id is resolved against the real
definitions. Progress is stored as named varp stages like other quests
rather than raw ints, which transmit as -1 through a map format.
Wydin, Luthas and the customs officer already had scripts, so the quest
extends those instead of duplicating them, reusing the existing
banana_plantation_job and banana_crate_bananas variables for the crate.
Karamjan rum is destroyed on every route off the island that this server
implements - customs search, the charmed dance, magic teleports and the
Shilo cart - and the routes that can't be covered yet are listed at the
bottom of PirateTreasure.kt.
Also fixed along the way:
- The Pay-fare gate checked questCompleted("Pirate's Treasure"), a
display name rather than the quest id, so with skipMissing enabled it
always passed. Pay-Fare also called search(), which opens the fare
dialogue and left the option hanging.
- The handwriting message scroll opened as a wide screen interface
rather than a screen one.
- The Port Sarim seamen spawned as ids that transform through the
unimplemented A Void Dance varbit, whose default maps to -1, leaving
them with no Talk-to option.
- Six npc definitions in the dungeoneering file duplicated ids
11700-11705, stealing them from the seamen and dispatching Lorris and
Thresnor to the makeover mage.
- Npc 1217 was missing its farmer's fork attack and defend animations
and its own combat definition.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GregHib
force-pushed
the
pirates-treasure
branch
from
September 2, 2026 11:53
79051c0 to
1dc6313
Compare
GregHib
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Karamjan rum is destroyed on every route off the island that this server implements and the routes that can't be covered yet are listed at the bottom of PirateTreasure.kt.
Also has a TODO in Redbeard Frank's dialogue for when Rum Deal is implemented.