Skip to content

Add Rum Deal quest - #1236

Merged
GregHib merged 10 commits into
mainfrom
rum-deal
Sep 2, 2026
Merged

Add Rum Deal quest#1236
GregHib merged 10 commits into
mainfrom
rum-deal

Combine quest commands

7b26274
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2026 in 0s

43.73% (-0.15%) compared to ea93f69

View this Pull Request on Codecov

43.73% (-0.15%) compared to ea93f69

Details

Codecov Report

❌ Patch coverage is 31.20905% with 1155 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.73%. Comparing base (ea93f69) to head (7b26274).

Files with missing lines Patch % Lines
...in/kotlin/content/quest/member/rum_deal/RumDeal.kt 32.44% 305 Missing and 26 partials ⚠️
...a/morytania/braindeath_island/CaptainBraindeath.kt 23.00% 313 Missing and 5 partials ⚠️
.../content/area/morytania/braindeath_island/Davey.kt 2.88% 101 Missing ⚠️
...content/area/morytania/braindeath_island/Brewer.kt 8.65% 93 Missing and 2 partials ⚠️
.../area/morytania/braindeath_island/CaptainDonnie.kt 2.81% 69 Missing ⚠️
...ent/area/morytania/braindeath_island/ZombieSwab.kt 24.19% 43 Missing and 4 partials ⚠️
...rld/gregs/voidps/engine/client/EncodeExtensions.kt 0.00% 41 Missing ⚠️
...gregs/voidps/engine/entity/character/mode/Leash.kt 0.00% 40 Missing ⚠️
...ontent/area/morytania/port_phasmatys/PiratePete.kt 75.64% 34 Missing and 4 partials ⚠️
...ame/src/main/kotlin/content/quest/QuestCommands.kt 66.66% 9 Missing and 12 partials ⚠️
... and 10 more
Additional details and impacted files
Files with missing lines Coverage Δ
...a/misthalin/lumbridge/swamp/chams_of_tears/Juna.kt 50.46% <ø> (+0.46%) ⬆️
...e/src/main/kotlin/content/entity/death/NPCDeath.kt 69.91% <100.00%> (+0.24%) ⬆️
...rc/main/kotlin/content/entity/death/PlayerDeath.kt 62.38% <100.00%> (+0.34%) ⬆️
...n/content/entity/player/modal/tab/QuestJournals.kt 60.00% <ø> (+10.00%) ⬆️
...n/kotlin/content/minigame/barrows/BarrowsCrypts.kt 62.58% <100.00%> (ø)
...me/src/main/kotlin/content/quest/InstanceLogout.kt 100.00% <100.00%> (ø)
game/src/main/kotlin/content/quest/Quest.kt 59.70% <100.00%> (+0.61%) ⬆️
...lin/content/quest/member/ghosts_ahoy/GhostsAhoy.kt 28.68% <100.00%> (ø)
...ain/kotlin/content/skill/farming/FarmingPatches.kt 100.00% <100.00%> (ø)
...tlin/world/gregs/voidps/cache/definition/Params.kt 0.00% <0.00%> (ø)
... and 19 more

... and 4 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1236      +/-   ##
============================================
- Coverage     43.87%   43.73%   -0.15%     
- Complexity    10445    10522      +77     
============================================
  Files          2061     2068       +7     
  Lines         93166    94671    +1505     
  Branches      15155    15321     +166     
============================================
+ Hits          40880    41404     +524     
- Misses        46420    47349     +929     
- Partials       5866     5918      +52
Components Coverage Δ
Content 43.99% <32.64%> (-0.19%) ⬇️
Engine 45.56% <0.00%> (-0.22%) ⬇️
Network 71.77% <60.00%> (+0.40%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov