Repository navigation
Name your devices from their last-resort KeyPackage (GRYT-1764) - #36
Merged
Merged
Conversation
A device you don't share a group with had no name, so a new one showed as a nameless "New device linked". The server now lists each of your devices with its last-resort KeyPackage, and ownDevices reads the name from it: only after the package verifies, and only if its certificate is for that device and under your own person key. Anything else leaves the device unnamed rather than misnamed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of GRYT-1764, with Gryt-chat/server#298. A device you don't share an MLS group with had no name, so a new one showed as a nameless "New device linked".
What changes
MlsListedDevicegets an optionallastResortKeyPackage, which the server now sends for your own devices.ownDevices()reads a device's name from it, after the group leaves. It only uses the name when:readMlsKeyPackageverifies the package (suite, lifetime, signature, certificate for this server and leaf key);Anything that fails stays unnamed rather than misnamed.
The fake delivery service lists your own devices with their newest last-resort package.
Checked
npm test: 210 pass.tsc --noEmitis clean.Look at: the trust check in
ownDeviceNames, thefor (const x of listed)block.Needs a core release, and the client to pick up that version. Until the server sends the field it does nothing.
GRYT-1764
🤖 Generated with Claude Code