Repository navigation
fix(agent): persist to Redis off the buffer lock and drain pending writes on stop - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
The Redis write no longer runs on the caller's thread or under the buffer lock: the key is minted under the lock and the write is submitted to a bounded persist pool (4 threads, queue of 1024) that stop drains for up to 10 seconds. A full or closed pool skips persistence and counts a persist failure. A record flushed or evicted before its write lands has its key deleted instead of left to TTL. The startup encryption error now reports its cause.