Repository navigation
chore(release): complete the 3.2.4 changelog and move the engine pin to 6cde4af - #28
Merged
Merged
Conversation
…to 6cde4af The 3.2.4 section now covers the Python reference parity work (#26), and CI, CodeQL and the release build check out guard-core-jvm at the 4.4.0 line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
The 3.2.4 version bump already landed in #24, so master already builds as 3.2.4. I am adding the missing #26 entries (responses, wire shape, persistence, stats) to the 3.2.4 CHANGELOG section, moving the pinned guard-core-jvm ref in ci.yml, code-ql.yml, release.yml, settings.gradle.kts and the docs from 2415a77 to 6cde4af (guard-core-jvm master, the 4.4.0 line), and updating the lockstep statements to engines at 4.4.0. The declared engine dependency stays
com.guard-core:guard-core:4.3.3in gradle/libs.versions.toml until 4.4.0 is on Maven Central, because the release build resolves it from Central with composite off.Gates run locally against the engine at the 4.4.0 bump:
./gradlew spotlessApply detekt(exit 0) and./gradlew build --no-daemon(exit 0). I am not tagging or releasing.