Repository navigation
ci(codeql): keep the engine checkout out of the scan - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the CodeQL
py/redosalert #1. It points atguard-core-jvm/docs/tools/w8c_extract.py, which is not this repository's code: the CodeQL workflow checks the engine out underguard-core-jvm/for the composite build, and the Python analysis I added in thecode-qljob scanned that checkout too..github/codeql/codeql-config.ymlnow listsguard-core-jvmunderpaths-ignoreand thecode-qljob loads it. The engine keeps its own alert in guard-core-jvm, where the fix lands. This repository's own Python scripts (src/test/resources/gen_response_vectors.py,gen_wire_shape.py) stay in the scan.Checked:
actionlintpasses on every changed workflow. The CodeQL run on this PR is the check that the alerts close.