Repository navigation
fix(docs-tools): make the Kotlin class regex linear - #74
Merged
Merged
Conversation
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the CodeQL
py/redosalert #1 ondocs/tools/w8c_extract.py:351.In
KT_CLASS_REthe annotation token@\w+[^ ]*can split a run of word characters between\w+and[^ ]*in many ways, so a line that starts with annotations and is not a class declaration backtracks exponentially.@\w\S*matches the same tokens with one parse:\w+[^ ]*and\w[^ ]*accept the same strings, and\S*no longer competes with the following\s+.Checked:
.ktline of this repository: 89789 lines, 691 class matches, 0 differences in the captured name."@" + "a0 @" * 22the old pattern takes 3.710 s (0.206 s at 18), the new one 0.000008 s.w8c_extract.pyis a docs tool; the Gradle build does not use it, so I did not run./gradlew buildfor this change.