Repository navigation
fix(docker): make the compose test path import the package and find the scripts - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test(the compose test service,pytest -v --cov=guard_core_mcp --cov-branch) gave 7 errors on master, on Python 3.10 and 3.14. It gives 157 passed here.This repo tracks
uv.lock(git ls-files uv.lockprints it), so--frozenand the lock mount are right and stay.ModuleNotFoundError: No module named 'guard_core_mcp', 6 errors). The Dockerfile copies the package afteruv sync, so the project was never installed in the image and nothing put/apponsys.path. I addeduv pip install --python .venv/bin/python --no-deps -e /appafter the copy, which is what guard-core's Dockerfile does.tests/test_sync_docs_script.pyloadsscripts/sync_docs.py, which the image did not contain (FileNotFoundError, 1 error). The Dockerfile now copiesscripts/.Verification, the compose test service run as the Makefile runs it, own compose project, master vs this branch:
Not verified: Python versions other than 3.10 and 3.14, hadolint cleanliness of this Dockerfile (it already had the apt and pip findings on master and I did not touch them), and the CI result (see the checks on this PR).