Repository navigation
docs(examples): drop the stale ssrf address-header workaround - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81
Removes the
logSensitiveHeadersaddress-header workaround fromexamples/simple_app/index.phpandexamples/advanced_app/src/config.php, rewrites the address-header note inexamples/simple_app/README.md, and drops the stale "delegated tologSensitiveHeaders" clause from the "Known surface gaps" line inAGENTS.md. The engine skipsssrffor the proxy identity headers by default and hasexcludedDetectionHeadersandexcludedSemanticDetectionHeaders, so the examples need no opt-out.docs/configuration.mdalready describes the real surface.The workaround was worse than the default: it skipped those headers from detection entirely. I ran both examples with
php -Sagainst Redis, before (origin/master) and after, with the same requests as the live smoke job plus forwarded-header cases. Before:X-Forwarded-For: <script>alert(1)</script>returned 200 (simple_app) andX-Forwarded-Host: <script>alert(1)</script>returned 200 (advanced_app). After: both return 400, whileHost: localhost,X-Forwarded-For: 203.0.113.9, 10.0.0.1andX-Real-IPstill return 200, the XSS query still returns 400, the bad user agent still returns 403, and the admin routes behave as before.Local gate:
make lintandmake test(36 passed, 0 failed) with Redis on 127.0.0.1. Only examples and docs changed, nosrc/.