Repository navigation
fix(detection): keep scanning after a value with no reportable category - #152
Merged
Merged
Conversation
A value whose threats were all category-filtered (disabled category or an excluded header skip set) ended the whole request scan as clean, and a semantic-only threat was never reported. Filtered values now fall through to the next value, and semantic threats report their attack type as the category like the reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix for GHSA-c9ww-6vhw-667p, shipping in 4.4.0.
scan_requestended the request scan as clean on a value that was a threat but had no reportable category: a value whose threats were all filtered out (a disabled category, a header skip set) returned an empty verdict immediately, so a later query, header or body value carrying an enabled attack was never scanned, and a semantic-only threat was never reported. A value none of whose threats is reportable is now treated as a miss and the scan continues, as the reference_check_value_enhanceddoes. Semantic threats report their attack type as the category and a threat with no threats list reports asuncategorized. The conformance pipeline runner follows the same rule.Probe tests in
detection_exclusionscover a filtered-out value followed by an attack, a disabled category, a semantic-only value, and the uncategorized case. The CHANGELOG 4.4.0 section notes the fix and the category-list change.