Repository navigation
fix(ci): lint on the MSRV toolchain like the release gate - #154
Merged
Merged
Conversation
clippy 1.92 rejected a long first doc paragraph and six test lock guards that stable clippy accepts, so the v4.4.0 tag failed its release gate. The doc comment gets a short summary line, the four overlay tests take the crate's usual significant_drop_tightening allow, and the MSRV CI job now runs the release gate's clippy command.
github-actions
Bot
added
ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
The v4.4.0 Release Gate failed because release.yml runs clippy with
-D warningson Rust 1.92.0 and PR CI never did. This fixes the eight findings (one long first doc paragraph in patterns/mod.rs, and the significant_drop_tightening guards in four dynamic_rules.rs overlay tests, using the allow the crate already uses for test lock guards), and adds the release gate's exact clippy command to the MSRV job so a PR can no longer pass and then fail at the tag.Local:
cargo +1.92.0 clippy --workspace --all-targets --exclude guard-core-python -- -D warningsfinishes clean,cargo fmt --checkand stable clippy exit 0, actionlint passes on ci.yml.