Repository navigation
perf(detection): charge the scan budget per pass and cut monitor overhead - #158
Merged
Merged
Conversation
…attern The per-request scan time budget read the thread CPU clock around every pattern. It now charges per pass: one read when a pass opens, one at each 2 ms wall-clock slice boundary and one when the pass closes. The per-pattern check reads only a cheap monotonic clock and compares the charged total, so the budget lags the true spend by at most one slice plus one pattern.
github-actions
Bot
added
the
area: engine
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
Port of the reference fix in Guard-Core/guard-core#173. ScanTimeBudget charges CPU per pass: open_pass reads the thread CPU clock once, tick reads only a cheap monotonic clock per pattern and charges the CPU clock when 2 ms have elapsed, and close_pass makes the final charge; the slice spans passes, exhausted() stays arithmetic only, and the wall-clock fallback stays for platforms without a thread CPU clock. Tests cover the clock reads per pass and a long pass stopping within one slice of the cap. On a ~1 KB JSON-like value plus 10 short header values detect went from 6.54 ms to 6.37 ms (release build); regex execution dominates the Rust cost, so the gain is small.