Repository navigation
chore(deps): pin netty to 4.1.139.Final through the netty BOM - #13
Merged
Merged
Conversation
Contributor
|
Thanks for opening your first pull request on ktor-guard! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See README.md for the adapter status. Welcome aboard - a maintainer will review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lettuce-core 6.8.2 declares netty 4.1.125, which carries twelve advisories, all fixed by 4.1.137 at the latest. This pins netty through
implementation(platform(io.netty:netty-bom:4.1.139.Final))and removes the netty osv-scanner suppressions.agentHandler.Why it is pinned here and not only in the engine (Guard-Core/guard-core-jvm#47): the engine's new BOM enters this repo's graph, and a lockfile without
io.netty:netty-bomfails resolution. That is what the engine PR's ecosystem gate hit. With the pin declared here too, this lockfile is identical whichever engine revision the build resolves.Verified locally:
--update-locks 'io.netty:*'against the pinned engine (2415a77), with./gradlew buildpassing../gradlew buildpassing against the engine branch of #47.GUARD_CORE_USE_COMPOSITE=false ./gradlew assemble(the publish path) passes.This merges before guard-core-jvm#47 so that its ecosystem gate passes. Nothing is released.