Repository navigation
test(agent): cover an injected agent handler and pin the engine to the telemetry fix - #14
Merged
Merged
Conversation
Contributor
|
Thanks for opening your first pull request on ktor-guard! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See README.md for the adapter status. Welcome aboard - a maintainer will review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ktor-guard's code already accepts an injected agent handler, but through the engine it never worked. guard-core-jvm only added an agent to its telemetry composite when it was a
HandlerAgentSink, which guard-agent-jvm'sGuardAgentTelemetryis not. The agent was therefore never started and received no events. That is fixed in Guard-Core/guard-core-jvm#48 (merged as 9067b7b).This PR:
InjectedAgentWiringTest:GuardAgentTelemetry-shaped handler is started, receives events and metrics (metrics via sendMetric), and is stopped onshutdown().Against the old pin, the second test fails with
expected: <1> but was: <0>.Local gate:
./gradlew buildpasses (37 tests, 0 failures) against guard-core-jvm 9067b7b. Nothing is released.