Repository navigation
fix(response): implement BoundedResponseBodyReader so body return patterns evaluate - #26
Merged
Merged
Conversation
…terns evaluate Closes #25
This was referenced Oct 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
I made KtorGuardResponse implement BoundedResponseBodyReader, returning a bounded prefix of the materialized body (empty when a streaming body was left unread), the same contract as the Python reference (guard/adapters.py:131-152). The test routes a body return_pattern rule with a one occurrence threshold and expects the ban on the third request; it fails on master with 200 instead of 403 and passes now. The full gate (spotlessApply, detekt, build with Redis) is green locally: 38 tests, 0 failed.