Repository navigation
fix(config): map EnableRateLimitAutoBan from PREST_GUARD_AUTO_BAN - #19
Merged
Merged
Conversation
github-actions
Bot
added
area: middleware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
buildEngineConfignow setsEnableRateLimitAutoBantogether withEnableIPBanning(on whenPREST_GUARD_AUTO_BANis set, off in passive mode), and the stale comment that said the knob was left unmapped is replaced. The fault was in the engine, whose route-aware rate limit check never fed the autoban counter; that is fixed in guard-core-go (Guard-Core/guard-core-go#97). Until this module requires an engine release carrying that fix, the knob is set but has no effect, so there is no behavior change today. A unit test pins the mapping (on, off, passive).