Repository navigation
release(1.1.0): the full engine config, engine-side exclusions and the engine floor guard-core-go v4.4.0 - #21
Merged
Merged
Conversation
…e engine floor guard-core-go v4.4.0
github-actions
Bot
added
documentation
nethttp-guard v1.5.0 is tagged and on the Go proxy; the CHANGELOG already records the floor move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
I raised the engine floor to
guard-core-go/v4 v4.4.0and prepared the v1.1.0 release entry.go.modandgo.summove for the engine, and I deflakedTestDeferredHandlerSwapsLiveGuardIn, which failed about 2 runs in 12 on master and on v4.4.0 because the background engine retry could win the race against the first request. The test now holds the retry until the 503 is observed (25 of 25 isolated runs and 6 of 6 full-raceruns pass).Version choice
Minor, v1.1.0. Since v1.0.1 the plugin gained exported
GuardConfigfields (EngineConfigJSON,Configure,TrustedProxyDepth) and the full engine config env surface, and no exported symbol was removed (go doc -alldiff against v1.0.1 shows additions only), so this is not a breaking change.nethttp-guard follow-up
The
nethttp-guardrequirement stays at v1.4.0 here: the v1.5.0 tag (which applies theCustomResponseModifier) is not published yet, and I do not reference an unpublished tag. After nethttp-guard v1.5.0 is tagged I will run this on this branch, rerun the gate and push:Gates (go1.26.5)
gofmt, go vet,
go test -race ./..., the plugin artifact build and govulncheck (go1.27.2) all exit 0. This repo has no release workflow and no integration tests; the tag is the release.