Repository navigation
chore: sync Cargo.lock with guard-core 4.3.3 and fix the docs markdown lint - #70
Merged
Merged
Conversation
… 4.3.3 Cargo.lock still pinned guard-core-engine and guard-core-rs at 4.3.2 while the sibling guard-core-rs master (the path dependency CI checks out) and crates.io are at 4.3.3, so every cargo run rewrote the lock. That drift is what made cargo publish refuse to package in tower-guard-rs #58. This updates only those two lock entries; the Cargo.toml floors stay at 4.3.2, which 4.3.3 satisfies. make lint and make test pass locally.
rennf93
added
no-issue
… lint pymarkdownlnt MD012 flagged README.md:61 (two consecutive blank lines), failing the Docs Update workflow's Lint markdown step on every master push.
rennf93
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.lock still pinned guard-core-engine and guard-core-rs at 4.3.2 while the sibling guard-core-rs master (the path dependency CI checks out) and crates.io are at 4.3.3, so every cargo run rewrote the lock. That drift is what made cargo publish refuse to package in tower-guard-rs #58. The first commit updates only those two lock entries; the Cargo.toml floors stay at 4.3.2, which 4.3.3 satisfies.
The Docs Update workflow has failed on every master push since at least 2026-10-09 at its Lint markdown step: README.md:61 was a second consecutive blank line (MD012). The second commit removes it. Locally the docs.yml lint command and mkdocs build --strict now pass, and make lint and make test pass.