Repository navigation
feat(parity): usage-rule order, live dynamic rules, strict routes, body timeout and the agent from config - #87
Merged
Merged
Conversation
…dy timeout and the agent from config
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86
I am closing the remaining reference-parity gaps in rocket-guard-rs: the route usage rules run after the check pipeline as the reference does, a dynamic rule changes the stages the adapter reads,
route_resolution_strictand the request-bodybody_read_timeoutare applied, the config is validated at construction, and the optionalagentandrediscargo features build the telemetry agent from the config and forward the Redis backend. The details and the reference locations are in the CHANGELOG entry.Merge order: guard-core-rs#144 first, then this PR. This PR builds against the engine change in Guard-Core/guard-core-rs#144 and shows red until that PR is merged.
Verification (local, stable 1.99): fmt, clippy
-D warnings(default and all features),cargo test,cargo test --features agent, docs with warnings denied, 100% line coverage and MSRV 1.92 check and test all pass.