Repository navigation
ci(release): publish a tag only from green CI, and re-drive by tag input - #91
Merged
Merged
Conversation
The release workflow no longer lints or tests at the tag. It requires the tagged commit's ci.yml, live-smoke.yml and security.yml push runs to have succeeded (waiting up to an hour), checks the tag against the crate version, and publishes through trusted publishing, skipping a version already on crates.io. A manual run takes a tag input and checks that tag out. ci.yml's MSRV job now runs fmt and clippy as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
Same change as guard-core-rs#156 and guard-agent-rs#64. The release workflow runs no lint or test of its own: it resolves the tag from the release event or the manual
taginput, checks it out, compares it to the crate version, requires the newest push run of ci.yml, live-smoke.yml and security.yml on that commit to have succeeded (waiting up to an hour), and publishes through trusted publishing, skipping a version already on crates.io. A re-drive is Actions > Release > Run workflow with the tag. The MSRV CI job now runs fmt and clippy, the lints the old release gate ran on 1.92.Local: actionlint clean on both files;
cargo +1.92.0 fmt --checkandcargo +1.92.0 clippy --all-targets -- -D warningsare clean on master, so the new CI steps start green. The engine change was proven end to end by dispatching guard-core-rs's release on v4.4.0 (run 38811883798: CI verified, both crates skipped as already published).