Repository navigation
chore(scaffold): community health files, phpstan static analysis, advanced app smoke - #20
Merged
Merged
Conversation
… and advanced app smoke - security policy, contributing guide, code of conduct, funding, pull request template, and issue template set (fastapi-guard baseline) - static analysis workflow: phpstan via docker (ghcr.io/phpstan/phpstan) on push/pr to master plus weekly cron, level 5, zero findings - live smoke: dockerized advanced_app job (port 8081), assertions: / and /health 200 plus the /admin x-admin-token gate 400 block
rennf93
force-pushed
the
ci/scaffold-baseline
branch
from
September 28, 2026 21:40
422ed60 to
abfe07a
Compare
rennf93
changed the title
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivers issue: none (repo chore, carries the
no-issuelabel)Description
Process scaffold roll-out to the PHP family, modeled on the Go family and the fastapi-guard baseline. Additive only: no existing workflow trigger is touched, no composer requirement or version change, composer.lock untouched.
Added
SECURITY.md: supported versions 1.2.x / 1.1.x, reporting via GitHub security advisories.CONTRIBUTING.md: php ^8.2, composer install,composer test/composer lint, PR rules (issue orno-issuelabel, lowercase conventional commits, no attribution trailers).CODE_OF_CONDUCT.md: verbatim from fastapi-guard..github/FUNDING.yml:github: rennf93, paypal custom link, tidelift commented out..github/PULL_REQUEST_TEMPLATE.md: verbatim from fastapi-guard..github/ISSUE_TEMPLATE/{bug,feature,docs,config}.yml: adapted (product name, docs URL https://rennf93.github.io/slim-guard/, php config render)..github/workflows/static-analysis.yml: phpstan via the docker pattern these repos already use (composer:2 install with the same ci-only path-repository patch as ci.yml, thenghcr.io/phpstan/phpstan:latest analyse src --level=5), on push/pr to master plus weekly cron0 5 * * 1. Level 5 is the highest level with zero findings on master (level 6 reports one)..github/workflows/live-smoke.yml: appended alive-smoke-advancedjob (existing simple_app job untouched), dockerized run ofexamples/advanced_app(host port 8081). Minimal assertions, only routes that exist in the app:GET /andGET /health200, plus one blocked-request assertion:GET /admin/check?ip=203.0.113.9withoutX-Admin-Tokenreturns the admin gate's 400 "Missing required header: X-Admin-Token".Skipped
code-ql.yml): drafted as directed, but the first run proved it cannot pass. GitHub CodeQL no longer supports PHP:github/codeql-action/init@2892aa5(v4.38.2, the Go family pin) fails in Initialize CodeQL withDid not recognize the following languages: php. The file was dropped from this PR to keep CI green. Added instead:.github/workflows/semgrep.yml(the PHP-capable substitute), running the pinnedsemgrep/semgrep:1.177.0container with thep/security-auditandp/secretsrulesets oversrc/(--error), path-filtered push/PR triggers plus a weekly Monday cron; SEMGREP_SEND_METRICS off.CHANGELOG.md: already exists.Verification
every touched workflow yaml-validated (pyyaml).
phpstan level ceiling probed locally with the same image on master sources: level 6 reports one finding (generic return type), level 5 is the highest level with zero findings.
the advanced_app compose stack was built and the exact job assertions executed locally against the app: all green.