Repository navigation
feat(properties): bind excluded-semantic-detection-headers and detection-max-scan-seconds - #23
Merged
Merged
Conversation
…ion-max-scan-seconds Closes #22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Adds
guard.excluded-semantic-detection-headersandguard.detection-max-scan-secondstoGuardPropertieswith theirGuardPropertiesMapperlines, plus binding assertions inGuardPropertiesBindingTest(shown failing on master:excludedSemanticDetectionHeadersbound[], then passing).The pinned engine (9067b7b) predates the two builder fields, so the engine pin moves to 09dfddf (guard-core-jvm #53) in
ci.yml,code-ql.yml,release.yml,settings.gradle.ktsand the docs that name it.I diffed the full
SecurityConfigBuilderfield list againstGuardProperties: only these two bindable fields were missing. The remaining builder-only names (authVerifier,cloudIpStore,customRequestCheck,customResponseModifier,geoIpHandler,onBlock,onError) are callbacks or handler objects reachable through customizers, anddynamicRulesCachePathRawand the threelogSensitive*Rawfields are internal twins of properties that are already mapped.Local gate:
./gradlew spotlessCheck detekt build --no-daemonpasses with Redis on 6379.