Repository navigation
release(2.0.0): engine routing parity, response pass before the flush - #40
Merged
Merged
Conversation
github-actions
Bot
added
documentation
guard-core 4.4.0 is on PyPI, so the floor moves up and upgrading this adapter brings the engine fixes. The release notes say so instead of asking users to upgrade guard-core separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release commit for 2.0.0: engine routing parity (#39).
SecurityMiddleware.apply_pre_flight_headersis removed, the engine response pass runs inSecurityHandler.finish()before the flush, a request with no client address is answered 403 under the defaultfail_secure, and theguard-corefloor moved to>=4.1.0in that PR. Version bump and release notes (this repo has no mike or versions.json).The version is a major because a public method is removed and
finish()now returns a future. The release notes carry a Breaking changes section with the upgrade action. The floor stays at>=4.1.0, so the guard-core 4.4.0 fixes arrive by upgrading guard-core.Nothing is tagged or released by this PR.