Skip to content

chore: sync Cargo.lock with guard-core 4.3.3, deflake the refresh wait coverage, fix the docs lint - #66

Merged
rennf93 merged 3 commits into
masterfrom
chore/lock-guard-core-4.3.3
Oct 14, 2026
Merged

rennf93 merged 3 commits into
masterfrom
chore/lock-guard-core-4.3.3

Conversation

@rennf93

@rennf93 rennf93 commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Cargo.lock still pinned guard-core-engine and guard-core-rs at 4.3.2 while the sibling guard-core-rs master (the path dependency CI checks out) and crates.io are at 4.3.3, so every cargo run rewrote the lock. That drift is what made cargo publish refuse to package in tower-guard-rs #58. The first commit updates only those two lock entries; the Cargo.toml floors stay at 4.3.2, which 4.3.3 satisfies.

CI on the first commit failed the 100% line gate on the two lines inside the cloud-refresh test's wait loop: while scheduler.refresh_in_flight() && ... { sleep } never runs its body when the background refresh finishes before the first check, so line coverage depended on timing (master passed the same gate). The second commit replaces it with (0..500).any(|_| { sleep; !in_flight }), whose closure always runs, with the same 5 second ceiling. A loop/if/break form was not enough: llvm-cov then reports the if's closing brace as uncovered when the first check succeeds.

The Docs Update workflow has failed on every master push since at least 2026-10-09 at its Lint markdown step: README.md:61 was a second consecutive blank line (MD012). The third commit removes it.

Local gates: make lint, make test, cargo llvm-cov plus .github/scripts/enforce_line_coverage.py (100% of executable lines), the docs.yml markdown lint and mkdocs build --strict all pass.

… 4.3.3

Cargo.lock still pinned guard-core-engine and guard-core-rs at 4.3.2 while the sibling guard-core-rs master (the path dependency CI checks out) and crates.io are at 4.3.3, so every cargo run rewrote the lock. That drift is what made cargo publish refuse to package in tower-guard-rs #58. This updates only those two lock entries; the Cargo.toml floors stay at 4.3.2, which 4.3.3 satisfies. make lint and make test pass locally.
@rennf93 rennf93 added no-issue No tracking issue applies to this change dependencies Cargo.toml or Cargo.lock labels Oct 14, 2026
…f timing

The while loop's body never ran when the background refresh finished before the first check, so the 100% line gate failed intermittently. any() over a bounded range always runs its closure once and keeps the 5 second ceiling.
… lint

pymarkdownlnt MD012 flagged README.md:61 (two consecutive blank lines), failing the Docs Update workflow's Lint markdown step on every master push.
@rennf93 rennf93 changed the title chore(deps): sync Cargo.lock with guard-core-engine and guard-core-rs 4.3.3 chore: sync Cargo.lock with guard-core 4.3.3, deflake the refresh wait coverage, fix the docs lint Oct 14, 2026
@github-actions github-actions Bot added documentation Docs, README, governance files area: lib Touches src/ (tower::Layer / tower::Service adapter — currently a single-file lib stub) labels Oct 14, 2026
@rennf93
rennf93 merged commit f48e1f4 into master Oct 14, 2026
11 checks passed
@rennf93
rennf93 deleted the chore/lock-guard-core-4.3.3 branch October 14, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: lib Touches src/ (tower::Layer / tower::Service adapter — currently a single-file lib stub) dependencies Cargo.toml or Cargo.lock documentation Docs, README, governance files no-issue No tracking issue applies to this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant