Repository navigation
fix(deps): remove orphaned Kotlin/JS yarn lock and overrides - #777
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kotlin-js-store/yarn.lock. No build has read it since the demo moved to Wasm (chore(web): migrate demo to Wasm #488), and all 5 open Dependabot alerts (shell-quote, source-map-js, proxy-addr, compression, braces) come from it.configureJsSecurityOverridesand its six npm*-securityversions. These Yarn resolutions only reach the JS Yarn root, which has no packages, so they never pinned anything.kotlin-js-store/wasm/yarn.lock(unchanged). Its test tooling (karma, webpack, mocha) comes from the Kotlin plugin's bundled install, which has its own lock. The removed resolutions never reached either one.build/wasm/package.jsonhas"resolutions": {}both before and after this change.Dependabot alerts on
kotlin-js-store/yarn.lock:Local Validation
./gradlew ktlintCheck./gradlew :charts-<module>:jvmTest./gradlew chartsTestJvm./gradlew ciCompile./gradlew chartsCheck./gradlew apiCompatibilityCheck../charts-playground/gradlew -p ../charts-playground -DchartsLocalPath="$PWD" ciCompile./gradlew :androidApp:validateDebugScreenshotTest./gradlew updateScreenshotsAlso ran
./gradlew kotlinWasmNpmInstall kotlinWasmToolingSetup kotlinWasmStoreYarnLock. All three passed andkotlin-js-store/wasm/yarn.lockwas unchanged.