Repository navigation
fix(sample): clear the Compose resource cache before the web demo loads - #778
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compose_web_resources_cacheon each page load but doesn't wait for it. In WebKit, resource loads read the old entries first, so returning visitors got the previous deploy'sstrings.commonMain.cvr. String decoding then threwIllegalArgumentException: The last unit of input does not have enough bits, andStartupGatenever removed the loader.index.htmlnow clears that cache and waits before it adds theHDCharts.jsscript tag. The tag is appended as a<script src>because webpack derives its publicPath from the last script tag.Local Validation
./gradlew ktlintCheck./gradlew :charts-<module>:jvmTest./gradlew chartsTestJvm./gradlew ciCompile./gradlew chartsCheck./gradlew apiCompatibilityCheck../charts-playground/gradlew -p ../charts-playground -DchartsLocalPath="$PWD" ciCompile./gradlew :androidApp:validateDebugScreenshotTest./gradlew updateScreenshotsAlso ran:
./gradlew :app:wasmJsBrowserDistribution, before and after the fix.strings.commonMain.cvrin the cache, reload.