Repository navigation
fix(publishing): separate Maven namespace deployments - #789
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maven Central rejected the 3.0.0 release because chart artifacts and relocation POMs were uploaded in one bundle containing two namespaces. Publish chart modules and the BOM first, then publish relocation POMs in a separate Gradle invocation so each deployment contains one namespace.
Local Validation
./gradlew ktlintCheck./gradlew :charts-<module>:jvmTest./gradlew chartsTestJvm./gradlew ciCompile./gradlew chartsCheck./gradlew apiCompatibilityCheck../charts-playground/gradlew -p ../charts-playground -DchartsLocalPath="$PWD" ciCompile./gradlew :androidApp:validateDebugScreenshotTest./gradlew updateScreenshotsAdditional validation:
-PchartsReleaseVersion=3.0.0 -PmavenCentralPublishing=true -PsignAllPublications=true --dry-run --no-daemon: the chart run contains all 11 new-namespace modules and excludes relocation; the relocation run contains only the 10 legacy publications.git diff --check. Actual Maven publishing will run in CI.