Repository navigation
Conversation
sriv144
marked this pull request as ready for review
October 29, 2026 06:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partner memory snapshots currently recognize only sessions renamed to
_archived_...jsonl. Web sessions usePartnerSessionStore.set_archived()instead, which keeps the history filename and stores the flag in_index.json. Archiving such a session therefore leaves its snapshot metadata atarchived: false, and the unchanged fingerprint produces no snapshot modification.Read the selected sessions directory's archive flags once and combine them with filename-based archive detection. Include archived state in fingerprints so archive/restore transitions are detected without editing history. Existing active-session fingerprints, IDs, history content, timestamps, and retention behavior are preserved. Archived sessions remain included as before. Missing, corrupt, or malformed sidecars do not hide readable history, and the adapter performs no writes.
Modules affected
dev.Validation
python3hook executable, an existing EOF blank line in an unrelated web test, and 27 broad mypy errors. The exact same 27 mypy errors were reproduced with unchanged production source. The unrelated hook formatting edit was preserved locally and restored. Changed-file hooks pass with those environment/baseline hooks skipped; direct hygiene and scoped mypy checks pass. Full pre-commit is not wholly green.Checklist
No running app, account, API credentials, model call, or GPU is required for these tests. No claim about model answer quality or memory consolidation quality is made.