Repository navigation
fix(settings): require a model ID and keep model panels URL-driven - #2159
Open
czcjsxmhqydncgg1 wants to merge 1 commit into
Open
czcjsxmhqydncgg1 wants to merge 1 commit into
czcjsxmhqydncgg1 wants to merge 1 commit into
Conversation
- The Add model panel now asks for a model ID (prefilled from provider defaults and discovered models) and keeps Continue disabled until it is filled, so an unusable row can no longer reach the draft. - The model editor marks a blank ID as required, explains it inline, and blocks "Set as default" until it is fixed. - Apply now names the first incomplete model and opens the page and row that can repair it, instead of failing with a message pointing nowhere. - Add/selection state lives in the URL, so refreshing no longer swaps the add panel for the list (or vice versa). - Backend guidance points at the current page names (Language models / Embedding models / Search) instead of the removed Catalog page. - Regression tests cover the add flow, URL state, editor validation, and the Apply preflight; new i18n keys for en/zh/de/pl/fr/uk. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the changes.
Related Issues
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
dev(notmain— see the base-branch selector above).pre-commit run --all-filesand fixed any issues.Additional Notes
Add any other context or screenshots about the pull request here.