fix: Studio declarative authoring manifest - #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1. Studio opens a declarative authoring manifest.
The reported file was a
tmforge-manifest(the reviewable sourcetmforge applybuildsfrom), not a model. No registered format claims it, so
detectreturned null, the Editorfell back to
tmforge-json, and the reader threw "Not a tmforge-json document."ManifestSupport.LooksLikeManifest— strict recognizer (requires an explicitschema).AuthoringService.ApplyManifestJson— builds a manifest supplied as text; returns ablocking problem on the result rather than throwing.
POST /v1/model/manifest, WASMApplyManifest, andIEngineClient.applyManifeston all three Studio clients (offline rejects honestly).Editorresolves Open/Import through onereadDocument: detect → manifest → fallback.2. The CLI reports unusable input instead of crashing.
tmforge open <manifest>produced an unhandled exception, a full crash dump, and exit 134.18 commands load a model through
CliModelLoaderand none guarded it.Program.Mainnowclassifies input failures, prints one line, and exits 1.
CliModelLoaderadditionally namesa manifest and points at
apply.