Repository navigation
feat: add Romanian and Hungarian alphabet support - #5
Merged
Merged
Conversation
Hungarian: alphabet data (hun) already existed in alphabet.json but had no Language enum entry. Added Language.Hungarian = "hun" so users can access it via by_language(). Romanian: data existed under "rum" (shared with Moldovan). Since Moldovan = "rum" in the enum, adding Romanian = "rum" would create an enum alias. Instead, used ISO 639-3 code "ron" and added a new "ron" entry to alphabet.json with the correct modern Romanian alphabet (comma-below diacritics: Ș ș Ț ț, not the legacy cedilla variants). Added tests for both alphabets verifying script content and length. Fixes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Hungarian
hun, 88 chars with multigraphs) already existed inalphabet.jsonbut had noLanguageenum entryLanguage.Hungarian = "hun"so users can access it viaby_language()Romanian
rum(shared with Moldovan). AddingRomanian = "rum"would create an enum alias ofMoldovan, soby_language(Language.Romanian)would return{"Moldovan": ...}ronand added a newronentry toalphabet.jsonwith the correct modern Romanian alphabet (comma-below diacritics: Ș ș Ț ț, not the legacy cedilla variants Ş ţ)Tests
test_hungarian_alphabet: verifies multigraphs (Cs, Dz, Dzs, Gy, Ly, Ny, Sz, Ty, Zs), accented vowels, and total count (88)test_romanian_alphabet: verifies special characters (Ă ă Â â Î î Ș ș Ț ț) and total count (62)All 26 tests pass.
Fixes #3