Skip to content

Optionals need to be handled better #5

Description

@Hammer1279

Optionals like the description field or the per domain timeout can easily break, for example leaving the timeout empty sets it as "[]" which will break the proxy and the description gets set to "" which prevents the default text, also the type detection makes it impossible to add a missing option.

Solutions are to either ignore empty fields, allow placeholder fields (such as the _ prefixed fields) or to have a type definition.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions