Skip to content

fix: resolve SonarCloud reliability regression (A→B) from nullable-references PR #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rexm merged 4 commits into from
Aug 6, 2026
+2 −2
Merged

fix: resolve SonarCloud reliability regression (A→B) from nullable-references PR #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa493b6
fix: resolve SonarCloud reliability regression from nullable-referenc…
rexm Aug 6, 2026
3de6c33
Merge branch 'master' into fix/sonar-reliability-s3887
rexm Aug 6, 2026
ebcac9f
fix: revert Closure.A to public to avoid new S3011 maintainability smell
rexm Aug 6, 2026
9c557e6
Merge remote-tracking branch 'origin/fix/sonar-reliability-s3887'
rexm Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/Handlebars/Compiler/ClosureBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public sealed class Closure
public readonly ChainSegment[]? BP0;
public readonly ChainSegment[][]? BPA;

public readonly object?[] A;
public readonly object?[] A; // NOSONAR: public since 2020; reflection-based codegen in this file needs public GetField lookup

internal Closure(
List<KeyValuePair<ConstantExpression, PathInfo>> pathInfos,
Expand Down
2 changes: 1 addition & 1 deletion source/Handlebars/PathStructure/PathInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private PathInfo(
/// </summary>
// [MemberNotNullWhen(true, nameof(Segments), nameof(TrimmedPath))]
public readonly bool IsVariable;
public readonly PathSegment[]? Segments;
public readonly PathSegment[]? Segments; // NOSONAR: public since v1.0 (2020); staying public avoids a breaking API change
public readonly string Path;
public readonly string? TrimmedPath;

Expand Down
Loading