Skip to content

Fix findFrame leak #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Geokureli merged 2 commits into from
Oct 30, 2026
Merged

Fix findFrame leak #3649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c494246
Fix findFrame leak
SimonArs Aug 10, 2026
9330a31
add findFrameWithBorder
Geokureli Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions flixel/graphics/frames/FlxAtlasFrames.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,14 +412,28 @@ class FlxAtlasFrames extends FlxFramesCollection
public static function findFrame(graphic:FlxGraphic, ?border:FlxPoint):FlxAtlasFrames
{
if (border == null)
border = FlxPoint.weak();

var atlasFrames:Array<FlxAtlasFrames> = cast graphic.getFramesCollections(FlxFrameCollectionType.ATLAS);

return findFrameWithBorder(graphic, 0, 0);

final result = findFrameWithBorder(graphic, Math.round(border.x), Math.round(border.y));
border.putWeak();
return result;
}

/**
* Returns the `FlxAtlasFrame` of the specified `FlxGraphic` object with the specified border.
*
* @param graphic `FlxGraphic` object to find the `FlxAtlasFrames` collection for.
* @return `FlxAtlasFrames` collection for the specified `FlxGraphic` object
* Could be `null` if `FlxGraphic` doesn't have it yet, or no atlas has the target border size.
*/
static function findFrameWithBorder(graphic:FlxGraphic, borderX:Int, borderY:Int):Null<FlxAtlasFrames> // TODO: Make public in next minor version (6.3.0)
{
final atlasFrames:Array<FlxAtlasFrames> = cast graphic.getFramesCollections(FlxFrameCollectionType.ATLAS);

for (atlas in atlasFrames)
if (atlas.border.equals(border))
if (Math.round(atlas.border.x) == borderX && Math.round(atlas.border.y) == borderY)
return atlas;

return null;
}

Expand Down
Loading