Repository navigation
fix(indexer,e2e): halt on unsupported event schema; stabilise layout snapshots - #839
Closed
UltimateUser1 wants to merge 1 commit into
Closed
UltimateUser1 wants to merge 1 commit into
UltimateUser1 wants to merge 1 commit into
Conversation
…el-Phone#757, Hel-Phone#747) - parser: events declaring an unsupported schemaVersion throw instead of silently dropping fields; undeclared versions keep the legacy path. - layout e2e: freeze CSS animations and mask live map canvases so screenshot diffs no longer depend on tile and animation timing.
|
@UltimateUser1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent fixes for P0 spikes:
#757: event schema version gate
Events that declare a
schemaVersionthe parser does not support now throwUnsupportedSchemaErrorinstead of silently dropping unknown fields. The supported set isSUPPORTED_EVENT_SCHEMA_VERSIONSinserver/indexer/parser.ts. Events without a declared version keep the existing decode path, so current indexing is unaffected.#747: deterministic layout snapshots
tests/e2e/layout.spec.tsnow freezes CSS animations and transitions before capture, and masks live map canvases alongside the existing video mask, so tile and pin re-rasters no longer change the diff.Not covered
schemaVersionemission and the WASM-hash to bindings registry (remaining # ISP-087: Contract WASM-hash upgrade migration vs bindings regen vs indexer parser version gate — clients, indexers and contracts on three versions at once #757 work) need contract changes.Closes #757
Closes #747