Skip to content

Fix offline i18n + RTL support for Arabic Help form #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikey-222 merged 2 commits into from
Oct 20, 2026
Merged

Fix offline i18n + RTL support for Arabic Help form #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b77ca
feat(pwa): precache Arabic locale files for offline i18n (#716)
makecoqibeso Oct 20, 2026
9727fa9
fix(i18n): improve RTL support and ARIA stability in Help page (#716)
makecoqibeso Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/pages/Help.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2910,8 +2910,8 @@ export default function Help() {
aria-expanded={searchSuggestions.length > 0}
aria-controls="hp-search-suggestions"
aria-activedescendant={
activeSuggestion >= 0
? `hp-suggestion-${activeSuggestion}`
activeSuggestion >= 0 && searchSuggestions[activeSuggestion]
? `hp-suggestion-${searchSuggestions[activeSuggestion].id}`
: undefined
}
/>
Expand Down Expand Up @@ -2963,7 +2963,7 @@ export default function Help() {
{searchSuggestions.map((feature, idx) => (
<button
key={feature.id}
id={`hp-suggestion-${idx}`}
id={`hp-suggestion-${feature.id}`}
role="option"
aria-selected={idx === activeSuggestion}
type="button"
Expand All @@ -2978,7 +2978,7 @@ export default function Help() {
? "rgba(255,255,255,0.07)"
: "transparent",
color: "rgba(242,236,220,0.9)",
textAlign: "left",
textAlign: "start",
cursor: "pointer",
display: "block",
}}
Expand Down Expand Up @@ -3525,7 +3525,7 @@ export default function Help() {
display: "flex",
alignItems: "center",
gap: "10px",
textAlign: "left",
textAlign: "start",
}}
>
<img
Expand Down Expand Up @@ -4059,7 +4059,7 @@ export default function Help() {
color:
i === mapStyleIndex ? "#B3A6FF" : "rgba(242,236,220,0.7)",
cursor: "pointer",
textAlign: "left",
textAlign: "start",
display: "block",
transition: "background 0.15s",
}}
Expand Down Expand Up @@ -4770,7 +4770,7 @@ export default function Help() {
border: `1.5px solid ${isSelected ? "#FF7A6B" : "rgba(255,255,255,0.08)"}`,
borderRadius: "14px",
cursor: "pointer",
textAlign: "left",
textAlign: "start",
transition: "border-color 0.15s, background 0.15s",
}}
>
Expand Down
13 changes: 11 additions & 2 deletions src/service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,17 @@ const ALLOWED_TILE_MIMES = [

self.addEventListener("install", (event) => {
event.waitUntil(
caches.open(CACHE_NAME).then(() => {
self.skipWaiting();
caches.open(CACHE_NAME).then((cache) => {
// ISP-046: Precache critical locale files for offline i18n support
// Ensures Arabic Help form renders offline without suspense hang
return cache.addAll([
'/locales/en/common.json',
'/locales/en/help.json',
'/locales/ar/common.json',
'/locales/ar/help.json',
]).then(() => {
self.skipWaiting();
});
}),
);
});
Expand Down