Repository navigation
fix(middleware): clear request timeout on close and propagate abort signal downstream (closes #910) - #916
Open
mopxam-art wants to merge 1 commit into
Open
fix(middleware): clear request timeout on close and propagate abort signal downstream (closes #910)#916mopxam-art wants to merge 1 commit into
mopxam-art wants to merge 1 commit into
Conversation
…ignal downstream (closes Heliobond#910)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #910 by ensuring that the pending request timer in
requestTimeoutmiddleware is cleared immediately when a client aborts/disconnects early (res.once("close")), preventing retained timer accumulation and subsequent write errors against dead responses. Additionally attaches anAbortControllersignal toreq.signal, propagating cancellation to downstream handlers when a timeout expires or when the client disconnects before the response completes.Changes
src/middleware/requestTimeout.ts:res.once("close")handler alongsidefinishto clear the pending timer upon early client disconnect.AbortControllerand attached its signal to(req as RequestWithSignal).signal.Request Timeout) and on premature client disconnect (Client disconnected).getTimeoutMsto fall back cleanly to defaults (30000ms / 60000ms) on invalid or non-positive environment variables.src/__tests__/requestTimeout-5d-matrix.test.ts:Verification
npx jest src/__tests__/requestTimeout-5d-matrix.test.ts).npx tsc --noEmit).npm run build).