Repository navigation
fix(api-keys): enforce upper bounds on consumer name, rate limit, rotation interval and grace period (closes #893) - #933
Open
mopxam-art wants to merge 1 commit into
Conversation
…ation interval and grace period (closes Heliobond#893)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces strict upper bounds and type validation on API-key management parameters in
src/routes/apiKeys.tsandsrc/lib/apiKeys.ts:consumer_namelength to 128 characters and rejects empty/whitespace strings.rate_limitto positive integers not exceeding 1,000,000 req/min.rotation_interval_daysto positive integers not exceeding 3,650 days (10 years).grace_period_msas an integer between 0 and 2,592,000,000 ms (30 days).grace_period_ms: 0explicitly as zero grace, immediately revoking old keys upon rotation.ERROR_RATE_LIMIT_WINDOW_MSinsrc/lib/error-limiter.tsensuring clean test suite execution.Testing & Verification
src/__tests__/apiKeysBounds-5d.test.ts).npm test).tsc --noEmitandnpm run lint(0 errors).Closes #893