Repository navigation
fix(events): isolate scoreEvents listener failures to prevent aborting binary feed broadcast and cron (closes #931) - #935
Open
mopxam-art wants to merge 1 commit into
Conversation
…g binary feed broadcast and cron (closes Heliobond#931)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolates
scoreEventslistener execution during score updates to prevent throwing subscribers from aborting the binary feed broadcast or failing the score-update cron:emitScoreUpdateSafelyinsrc/lib/events.tsto dispatchSCORE_UPDATE_EVENTwith per-listener try/catch isolation and asynchronous promise rejection handling.broadcastScoreUpdate(src/lib/websocket.ts) within a defensive try/catch block so exceptions never bypass binary WebSocket frame distribution.ERROR_RATE_LIMIT_WINDOW_MSinsrc/lib/error-limiter.ts.Testing & Verification
src/__tests__/broadcastScoreEventsIsolation.test.ts(111 tests) covering boundary payloads, throwing listener combinatorics, async rejections, subscriber mutations during dispatch, and memory leak absence.npm test- 1,530 tests green).tsc --noEmitandnpm run lint(0 errors).npm run build).Closes #931