Repository navigation
fix(websocket): enforce maxPayload and bound incoming frame sizes (closes #929) - #937
Open
mopxam-art wants to merge 1 commit into
Open
mopxam-art wants to merge 1 commit into
mopxam-art wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WebSocket servers (
/wsand/ws/events) were instantiated without an explicitmaxPayload, defaulting to ws library's 100 MiB limit. In addition,handleMessagelacked raw byte length guards before JSON parsing incoming payloads, allowing oversized frames to allocate unbounded memory.What
maxPayload: WS_MAX_PAYLOAD_BYTES(64 KiB default, configurable viaWS_MAX_PAYLOAD_BYTES) on both/wsand/ws/eventsWebSocketServerinstances insrc/lib/websocket.ts.handleMessagethat terminates oversized frames with close code1009 payload too largebefore parsing JSON.handleMessage.WS_MAX_PAYLOAD_BYTESand close code 1009 inAPI.md.src/__tests__/websocket-max-payload.test.ts).Verified
jest src/__tests__/websocket-max-payload.test.ts, 114 tests pass).npm run typecheck) and linter (npm run lint) clean with 0 errors.npm run build) succeeds cleanly.Closes #929